Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Robustness] Replace isNegativeZero helper with is-negative-zero dependency #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bartekleon
Copy link

As discussed in #154 , replaced isNegativeZero with a dependency to remove unnecessary code duplication.

Comment on lines +3 to +5
var isNegativeZero = require('is-negative-zero');

module.exports = isNegativeZero;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var isNegativeZero = require('is-negative-zero');
module.exports = isNegativeZero;
// TODO, semver-major: remove
module.exports = require('is-negative-zero');

Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also change all instances inside the package using the helper, to directly using the dep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants